[bar-chart] Fix issue with non-string names in series title #5433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5433 +/- ##
==========================================
+ Coverage 63.49% 63.49% +<.01%
==========================================
Files 360 360
Lines 22896 22894 -2
Branches 2551 2551
==========================================
Hits 14537 14537
+ Misses 8344 8342 -2
Partials 15 15
Continue to review full report at Codecov.
|
williaster
approved these changes
Aug 15, 2018
john-bodley
added a commit
to john-bodley/superset
that referenced
this pull request
Aug 15, 2018
(cherry picked from commit 4e3b2e7)
john-bodley
added a commit
to airbnb/superset-fork
that referenced
this pull request
Aug 15, 2018
[title] Fix issue with non-string names in series title (apache#5433)
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue when the
namelist could contain a non-string, i.e., when grouping by a column which is an integer. The fix is similar to the previous logic when there's a single metric by casting the name(s) to a string.to: @graceguo-supercat @michellethomas @mistercrunch @timifasubaa